Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modified domain on sale order line route_id #2

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: modified domain on sale order line route_id #2

merged 1 commit into from
Feb 15, 2024

Conversation

victorvermot
Copy link

@santostelmo
Copy link
Member

Please fix pre-commit and change the commit message to something like
[FIX] sale_stock_partner_warehouse: domain on sale order line route_id

@victorvermot victorvermot force-pushed the 16-0-fix-sale-stock-warehouse-multicompany branch from bfc6688 to dec0ea7 Compare February 13, 2024 08:05
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

santostelmo
santostelmo requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@santostelmo santostelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expression does not seems correct.
[('company_ids', 'in', company_id),('sale_selectable', =,true)]

Is possible to add a unit test where we use sale_selectable ?

@victorvermot victorvermot force-pushed the 16-0-fix-sale-stock-warehouse-multicompany branch from dec0ea7 to 263e31e Compare February 14, 2024 16:31
@santostelmo santostelmo force-pushed the 16-0-fix-sale-stock-warehouse-multicompany branch from 263e31e to 7dc0c78 Compare February 15, 2024 10:59
@santostelmo santostelmo merged commit f9847d0 into 16.0-add-sale-stock-warehouse-multicompany Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santostelmo santostelmo santostelmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorvermot @santostelmo @codecov-commenter